Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track signals in useClientEffect() #1640

Merged
merged 1 commit into from Oct 7, 2022
Merged

Conversation

manucorporat
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e24af6
Status: ✅  Deploy successful!
Preview URL: https://750d3339.qwik-docs.pages.dev
Branch Preview URL: https://fix-client-effect-crash.qwik-docs.pages.dev

View logs

@manucorporat manucorporat merged commit cd40e90 into main Oct 7, 2022
@manucorporat manucorporat deleted the fix-client-effect-crash branch October 7, 2022 23:16
youngboy added a commit to youngboy/qwik that referenced this pull request Oct 8, 2022
* main: (106 commits)
  fix: party town action required (QwikDev#1624)
  docs: deleting instructions seen in the next step (QwikDev#1628)
  docs: corrected docs path urls (QwikDev#1634)
  fix: qrl resolution (QwikDev#1638)
  fix: resource pending in ssr (QwikDev#1641)
  fix: track signals in useClientEffect() (QwikDev#1640)
  docs: Getting Started update Commands (QwikDev#1622)
  fix: freeze of stores (QwikDev#1639)
  docs: remove no longer used commands from getting started page (QwikDev#1637)
  docs: simple changes for new version's CLI (QwikDev#1633)
  fix(optimizer): don't strip import assertions (QwikDev#1629)
  feat: improve deno support (QwikDev#1613)
  feat(cli): action required (QwikDev#1609)
  chore: update docs (QwikDev#1623)
  On input (QwikDev#1599)
  docs: typo (QwikDev#1612)
  fix: serialize non finite numbers (QwikDev#1617)
  fix: autoprefixer error (QwikDev#1608)
  release: qwik-city 0.0.112 (QwikDev#1606)
  docs: Update qwikcity/data/overview (QwikDev#1603)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant