Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new site to showcase room #2833

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Added new site to showcase room #2833

merged 2 commits into from
Feb 5, 2023

Conversation

adnanebrahimi
Copy link
Contributor

tatbiqit.com is the official website of Tatbiqit company located in Kuwait developed by Qwik.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Adding a new website to the showcase page, this website is the official website of a Kuwaiti company called Tatbiqit.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

tatbiqit.com is the official website of Tatbiqit company located in Kuwait developed by Qwik.
@stackblitz
Copy link

stackblitz bot commented Feb 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@manucorporat manucorporat merged commit 8b1c5a8 into QwikDev:main Feb 5, 2023
@Dindaleon
Copy link

Hello,

The first load is almost 300kB of javascript, isn't Qwik suppose to be 0b load of js? Is it possible to make your site load 0b js? Just wondering, otherwise, I believe it would the defeat one of the main purposes of using qwik.

@adnanebrahimi
Copy link
Contributor Author

@Dindaleon
I believe you have seen some js in the network tab which is from cloudflare email protection.
Other js that is loading externally is Google analytics service which is loaded by partytown

@Dindaleon
Copy link

Dindaleon commented Feb 8, 2023

Please let me know if I am looking at the wrong thing. I captured my network tab when loading the site. I do see cloudflare and email protection but I also see a bunch of q- prefixed js. I did not scroll down the page by the way, it's a fresh load.

Screenshot 2023-02-08 at 2 36 04 PM

@adnanebrahimi
Copy link
Contributor Author

adnanebrahimi commented Feb 8, 2023

Did you cleared the network tab before reloading? Because I see the request get duplicated. I will check it once i get back at my desk

@Dindaleon
Copy link

tatbiqit.com

yeah, I cleared it. Please let me know what's going on because I am very curious about it. While writing some code I noticed that whatever we put inside useClientEffect$ hook will run on load once no matter what. However, if we want to lazy load the code, we need to use other hooks such as useTask

@adnanebrahimi
Copy link
Contributor Author

adnanebrahimi commented Feb 9, 2023

@Dindaleon
I didn't see anything abnormal in the request waterfall.
https://gtmetrix.com/reports/tatbiqit.com/O85dXETV/

regarding the q-* files there is an exciting metal model in Qwik resumibility, the js of components that getting visible in the viewport will be downloaded with the service worker in the background thread but still didn't connect to the DOM. for example if you see a button, the JS of that button will be downloaded via service worker but the event listener of that button is not connected to that button yet after you clicked on that button the js will be downloaded from the service worker and connected and executed.

It's complicated I hope I answered correctly.
@manucorporat can answer better than me for sure :)

@Dindaleon
Copy link

Those files are not being downloaded by the service worker. They are being downloaded directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants