Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure-swa): azure SWA request handling and generation of function.json #2868

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

derkoe
Copy link
Contributor

@derkoe derkoe commented Feb 7, 2023

This fixes two issues for Azure Static Web Apps adaptor:

  • the URL was not taken from the header x-ms-original-url
  • the function.json was missing the scriptFile entry

Fixes #2867

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

See above

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

….json

This fixes two issues for Azure Static Web Apps adaptor:
- the URL was not taken from the header `x-ms-original-url`
- the function.json was missing the `scriptFile` entry

Fixes QwikDev#2867
@stackblitz
Copy link

stackblitz bot commented Feb 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@adamdbradley
Copy link
Contributor

Thanks for fixing this up. I'd like to add azure to our server e2e testing, which you can see is on the TODO list: https://github.com/BuilderIO/qwik-city-e2e

@adamdbradley adamdbradley enabled auto-merge (squash) February 7, 2023 22:20
@adamdbradley adamdbradley merged commit 2fe931c into QwikDev:main Feb 7, 2023
genki pushed a commit to genki/qwik that referenced this pull request Feb 10, 2023
….json (QwikDev#2868)

This fixes two issues for Azure Static Web Apps adaptor:
- the URL was not taken from the header `x-ms-original-url`
- the function.json was missing the `scriptFile` entry

Fixes QwikDev#2867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] Azure Static Web Apps: intgration is broken since v0.17.0
2 participants