Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): app name is a placeholder again #4031

Merged
merged 3 commits into from
May 3, 2023
Merged

fix(cli): app name is a placeholder again #4031

merged 3 commits into from
May 3, 2023

Conversation

zanettin
Copy link
Collaborator

@zanettin zanettin commented May 3, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

fixes #4026

To cover all requirements, we've switched back to a placeholder value and added a new hint how to install into the current directory.
Bildschirmfoto_2023-05-03_um_07_13_41

Testing Instructions

  • run pnpm cli
  • quit it right away (we just need the file statics in place)
  • create a new directory
  • cd into it
  • run node ../packages/create-qwik/dist/create-qwik.cjs
  • add . or ./ when asked for the app directory
  • check the new output line where the app will be installed
  • install and check the output
  • redo all of them but also add at least one file into the new created directory to check the handling there

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented May 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 863c9a5
Status: ✅  Deploy successful!
Preview URL: https://6316d775.qwik-docs.pages.dev
Branch Preview URL: https://fix-4026.qwik-docs.pages.dev

View logs

@manucorporat manucorporat merged commit 3d17ffe into main May 3, 2023
22 checks passed
@manucorporat manucorporat deleted the fix/4026 branch May 3, 2023 07:56
@manucorporat
Copy link
Contributor

Amazing man! you rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] Creating a new Qwik app pre-populates the name field instead of using a placeholder
2 participants