fix: service-worker.js should work with basePathname #4044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
See this bug: #4043
This PR fixes
service-worker.js
generation with non-rootbasePathname
by adding thebasePathname
in the path when looking for theservice-worker.js
toprependManifestToServiceWorker
.Use cases and why
The expected behavior is the
service-worker.js
should intercept and cache the Qwik files properly.Checklist: