Improve type for userEvent of createDOM
#4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ahnpnl
force-pushed
the
improve-create-dom-type
branch
from
d79ac08
to
d74ea13
Compare
|
Not sure why build failed with error which doesn't seem to be related to the change |
|
Hi @ahnpnl 👋 |
ahnpnl
force-pushed
the
improve-create-dom-type
branch
2 times, most recently
from
c4c65f8
to
6ba5c5e
Compare
This will provide better typing that: - `queryOrElement` can give suggestion about all available HTML tags - `eventNameCamel` can give suggestion about all existing DOM events
ahnpnl
force-pushed
the
improve-create-dom-type
branch
from
6ba5c5e
to
5f46414
Compare
|
awesome thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Currently, when using
userEvent, it's not so convenient that devs don't know which native HTML element tags are available as well as available DOM events.This PR will provide better typing that:
queryOrElementcan give suggestion about all available HTML tagseventNameCamelcan give suggestion about all existing DOM eventsChecklist: