Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve useContextProvider's wording. #4084

Conversation

igalklebanov
Copy link
Member

@igalklebanov igalklebanov commented May 6, 2023

Overview

Hey 馃憢

Typo, me confused. 馃槙

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

So so confused.

Use cases and why

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented May 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Co-authored-by: Naor Peled <6171622+naorpeled@users.noreply.github.com>
@igalklebanov igalklebanov force-pushed the igalklebanov-fix-use-context-provider-wording branch from 218dbbd to 0bf74ce Compare May 6, 2023 14:05
Co-authored-by: Naor Peled <6171622+naorpeled@users.noreply.github.com>
@igalklebanov igalklebanov marked this pull request as ready for review May 6, 2023 14:11
@shairez
Copy link
Collaborator

shairez commented May 6, 2023

thanks @igalklebanov and @naorpeled ! 馃檹

@shairez shairez merged commit 28925ef into QwikDev:main May 6, 2023
19 checks passed
@igalklebanov igalklebanov deleted the igalklebanov-fix-use-context-provider-wording branch May 6, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants