fix: allow false type in BaseClassList
#4112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows for doing things like this
```
class={[
!show.value && 'hidden',
'text-white ...'
]}
```
I quite like this format compared to objects, and right now I instead have to do this due to `false` not being allowed
```
class={[
!show.value ? 'hidden' : null,
'text-white ...'
]}
```
|
|
steve8708
changed the title
false in BaseClassListfalse in BaseClassList
steve8708
changed the title
false in BaseClassListfalse type in BaseClassList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
this allows for doing things like this
I quite like this format compared to objects, and right now I instead have to do this due to
falsenot being allowedFrom what I can tell
serializeClassalready supports this, we just need the typings to reflect thatWhat is it?
Checklist: