docs: api docs fixed markdown links #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wmertens
reviewed
May 18, 2023
| @@ -118,7 +118,7 @@ export interface QwikLoaderOptions | |||
|
|
|||
| | Property | Modifiers | Type | Description | | |||
| | -------------- | --------- | ----------------------------- | ------------ | | |||
| | [events?](#) | | string\[\] | _(Optional)_ | | |||
| | [events?](#) | | string[] | _(Optional)_ | | |||
There was a problem hiding this comment.
Is this correct? Shouldn't this stay the same since it's not a link?
There was a problem hiding this comment.
thanks for the review @wmertens 🙏 it shouldn't affect the output though. it's escaped by the api extractor but not needed to be imo on an .md file. do you see an issue with it? thanks again for your input 😃
Deploying with
|
| Latest commit: |
606e772
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98b76e68.qwik-docs.pages.dev |
| Branch Preview URL: | https://fix-api-markdown-links.qwik-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
Fixed markdown links in the API docs. thx @wmertens for the heads-up 🙏
Screenshots
Before
After
Light overview color adjustment
Checklist: