Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/qwik-nutshell/index.mdx): fix typo on variable name #4269

Merged
merged 1 commit into from
May 19, 2023

Conversation

julianobrasil
Copy link
Contributor

@julianobrasil julianobrasil commented May 19, 2023

Overview

In the useTask$ example, a signal is created with the name currentPage. Later on the same example it's referred as "page" only.

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

In the useTask$ example on the guides/qwik-nutshell, a signal is created with the name currentPage. Later on the same example it's referred as "page" only.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • [] Added new tests to cover the fix / functionality

…dex.mdx): fix typo on var name

In the useTask$ example, a signal is created with the name currentPage. Later on the same example
it's referred as "page" only.
@stackblitz
Copy link

stackblitz bot commented May 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zanettin zanettin added the COMP: docs Improvements or additions to documentation label May 19, 2023
@zanettin zanettin enabled auto-merge (squash) May 19, 2023 19:13
@zanettin
Copy link
Collaborator

thanks a lot for the adjustment @julianobrasil 🙏 and welcome 🎉

@zanettin zanettin merged commit 1240014 into QwikDev:main May 19, 2023
19 checks passed
@julianobrasil julianobrasil deleted the fix-signal-name-typo-in-docs branch May 20, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants