Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove ambiguity on "Composing Components" #4301

Merged
merged 3 commits into from
May 23, 2023

Conversation

neonpie
Copy link
Contributor

@neonpie neonpie commented May 23, 2023

extended instruction to resolve potential confusion

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

extended instruction to resolve potential confusion
@stackblitz
Copy link

stackblitz bot commented May 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@@ -6,4 +6,4 @@ contributors:

Components are composed together to build applications.

In this example, the `<App />` and `<Greeter />` components are prepared for you. For this exercise, place the `<Greeter />` component inside the `<App />` component to see its contents.
In this example, the `<App />` and `<Greeter />` components are prepared for you. For this exercise, place the `<Greeter />` component inside the `<App />` (default export) component to see its contents.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

can you please add "the" , like in -
"(the default export)"

@shairez
Copy link
Collaborator

shairez commented May 23, 2023

thanks @neonpie !
add a comment

if possible, for next time, please give a more descriptive name for your PR (so we'll know to differentiate between them, and also for the future changelog, thanks)

@neonpie neonpie changed the title Update index.mdx Extended instruction to resolve potential confusion May 23, 2023
@neonpie neonpie requested a review from shairez May 23, 2023 08:14
@neonpie neonpie changed the title Extended instruction to resolve potential confusion docs: extended instruction to resolve potential confusion May 23, 2023
@neonpie neonpie changed the title docs: extended instruction to resolve potential confusion docs: remove ambiguity on "Composing Components" May 23, 2023
@zanettin zanettin added the COMP: docs Improvements or additions to documentation label May 23, 2023
@zanettin zanettin merged commit cfbce86 into QwikDev:main May 23, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants