feat: add staleIfError option for request.cacheControl, also adds docs on caching and caching to starters #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
steve8708
changed the title
|
also added some caching default to our starters with links to docs |
steve8708
changed the title
| ```tsx title="src/routes/layout.tsx" | ||
| import type { RequestHandler } from "@builder.io/qwik-city"; | ||
|
|
||
| export const onGet: RequestHandler = async (request) => { |
There was a problem hiding this comment.
I think use the destructured version of this, like
async ({ cacheControl }) =>
Technically the object is a RequestEvent, so I think naming it just a request and setting response caching may be confusing in the docs.
There was a problem hiding this comment.
ah cool easy, on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
This is a really useful cache-control directive to avoid unnecessary downtime - allowing the CDN to serve stale responses when your origin is down
Also added a doc on caching, and added default caching to our starters
Checklist: