Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing media type in DocumentMeta #4327

Merged
merged 3 commits into from
Jun 1, 2023
Merged

fix: missing media type in DocumentMeta #4327

merged 3 commits into from
Jun 1, 2023

Conversation

GrandSchtroumpf
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

fix #4220

Use cases and why

see #4220

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (N/A)
  • Added new tests to cover the fix / functionality (N/A)

@stackblitz
Copy link

stackblitz bot commented May 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@GrandSchtroumpf GrandSchtroumpf mentioned this pull request May 24, 2023
Closed
@manucorporat
Copy link
Contributor

will need to run:

pnpm api.update

since the public API changed!

@manucorporat manucorporat merged commit fd3833a into QwikDev:main Jun 1, 2023
19 checks passed
@manucorporat
Copy link
Contributor

Thank you very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
COMP: qwik-city
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] DocumentMeta should support media property
3 participants
@GrandSchtroumpf @manucorporat @zanettin