Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import styles naming fixing #4333

Merged
merged 3 commits into from
May 28, 2023
Merged

Import styles naming fixing #4333

merged 3 commits into from
May 28, 2023

Conversation

lanc3lo1
Copy link
Contributor

@lanc3lo1 lanc3lo1 commented May 25, 2023

Deprecated full capitalized import

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Deprecated import from index.mdx at Styles chapter.

Checklist:

Deprecated full capitalized import
@stackblitz
Copy link

stackblitz bot commented May 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zanettin zanettin added the COMP: docs Improvements or additions to documentation label May 26, 2023
@zanettin
Copy link
Collaborator

Hi @lanc3lo1 👋
Thanks for the adjustment 🙏 just added a code highlight adjustment to make it visually a bit clearer how it is used.
Would you mind to also adjust the file 06-styling/index.tsx file located in packages/docs/src/routes/demo/getting-started/06-styling/index.tsx? that would be nice 🙏
and congrats to your first PR on this repo 🎉

@manucorporat manucorporat merged commit f42c133 into QwikDev:main May 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants