fix: allow undefined ref prop #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The PR looks great! but we might need to a test, i think the best would be a e2e test. In this file, let's add a new component: then a test here: Notice, it should be some new component that somehow breaks the current e2e test, but passes with the fix! |
|
Awesome, i've added a test to go along with it |
|
Awesome work!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
Allow undefined to be passed into ref props.
Fixes #4346
If this is not how you would approach this problem @manucorporat, let me know! But hopefully this is a quick win.
Use cases and why
Please see the linked issue above for a use case example
Checklist: