fix(deno middleware): serve static assets in Deno middleware as binary data

[jaroel]

Overview

Fixes #4345

What is it?

• Feature / enhancement
• Bug
• Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

• Safari didn't show images.

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• Added new tests to cover the fix / functionality

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[jaroel]

I've checked this change by applying it to an existing (previously failing) install. Please have someone actually check it as well and we should be grand.

[manucorporat]

This is amazing!!! in order to check that it works, how do we do it? do you have some image that reproduced the issue?

Thinking to include that in our e2e test for deployments (which also tests Deno)(https://github.com/builderIO/qwik-city-e2e)

[jaroel]

Importing any old image should do as all images were broken.
I have something along the lines of

import { component$ } from "@builder.io/qwik";
import theLogo from "~/assets/logos/thelogo.png";


export default component$(() => {
  return (
    <>
      <img
        src={theLogo}
        loading="eager"
        decoding="auto"
      />
    </>
  );
});

Then I ran pnpm run build and pnpm run serve. When using Deno it breaks images, Node works Just Fine(tm) :)

[manucorporat]

I can indeed reproduce the issue, added a new e2e test!
QwikDev/qwik-city-e2e@8941dd4

[manucorporat]

Let's goo!! thank u so much @jaroel