fix(Docs): Social media OG image URL generation update #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
Prettier had formatted the import as 👇
import { type RequestHandler } from '@builder.io/qwik-city';
instead of 👇
import type { RequestHandler } from '@builder.io/qwik-city';
In this updated version of the code, I've further optimized the implementation by encapsulating all the necessary logic within the OGImage object. Unnecessary variables like routeLevel and isBaseRoute have been removed to streamline the code and improve clarity. Here's a breakdown of the changes: Encapsulation: All logic related to generating the OpenGraph image URL has been encapsulated within the OGImage object. This approach enhances code organization and makes it easier to manage and maintain. Simplified Logic: The code now directly extracts the title and subtitle from the provided input and constructs the OpenGraph image URL accordingly. Unnecessary checks and variables have been eliminated, resulting in a more concise and efficient implementation. URL Generation: The URL generation process remains similar to the previous version, but with improved clarity and reduced complexity. The code now focuses solely on generating the appropriate URL based on the provided title and subtitle.
wmertens
approved these changes
Mar 30, 2024
|
@mrhoodz can you point me to how we can remove the word "qwik" in the qwik logo on the og images? I'm not seeing it in the repo 
the logo is intended to not have the word "qwik" inside the lightening bolt, I'm happy to fix it just need to be pointed to where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is it?
Description
The previous implementation used useSignals and useTask$ unnecessarily, which could cause delays in generating the Open Graph (OG) image URL and result in blank OG previews when shared. This pull request introduces an OGImage object that efficiently handles the dynamic OG image generation, leading to faster generation of the image URL and improved performance in creating OG previews.
Use cases and why
Checklist: