Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): fix layout for non-default html font-size #6007

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

oleasteo
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Layout Glitch

Description

Make layout work independent of browser font-size setting.

Use cases and why

See #5853

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation Not applicable
  • Added new tests to cover the fix / functionality Not applicable

Copy link

netlify bot commented Mar 13, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6f9eaa8

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 565311b into QwikDev:main Mar 30, 2024
22 checks passed
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @asteo-net

@wmertens
Copy link
Member

@asteo-net unfortunately this PR breaks the sidebar. I had to revert it. Can you fix and make a new PR?

@oleasteo
Copy link
Contributor Author

@wmertens If you can point me to the exact issue, sure. I just tested with latest changes on docs/ and community/groups/ but did not notice anything wrong. What are you looking at?

@wmertens
Copy link
Member

wmertens commented Mar 30, 2024

clone main and go back one commit, before the revert.
The sidebar wasn't working on mobile sizes, it was only showing a darker page when you clicked it.
After reverting and deploying, the sidebar worked again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants