Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ✏️ Change element mentioned in useSignal tutorial #6016

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

geertjanOSS
Copy link
Contributor

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

The tutorial text asks to change an input element that is not part of the code challenge. The code contains an aside element. And the solved code alters that aside element

Use cases and why

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Mar 15, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8995ebf

In useSignal tutoral, update the mention of a non-existing `input`
element to the `aside` element in the problem and solution code.
@geertjanOSS geertjanOSS changed the title useSignal tutorial, fix element tagname docs: ✏️ Change element mentioned in useSignal tutorial Mar 15, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks @geertjanOSS

@gioboa gioboa marked this pull request as ready for review March 15, 2024 07:59
@gioboa gioboa enabled auto-merge (squash) March 15, 2024 07:59
@gioboa gioboa merged commit 9959b18 into QwikDev:main Mar 15, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants