Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare-adapter): don't add a node-version #6038

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

steve8708
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

node.js 16 is incompatible with the latest qwik, it creates the error "ReadableStream is not defined" on build

for some reason, we are specifying an unsupported nodejs version when using the adapter

instead, lets just delete this

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • [] I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

node.js 16 is incompatible with the latest qwik, it creates the error "ReadableStream is not defined" on build

for some reason, we are specifying an unsupported nodejs version when using the adapter

instead, lets just delete this
Copy link

netlify bot commented Mar 21, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 42dce2d

@mhevery mhevery enabled auto-merge (squash) March 21, 2024 16:49
@mhevery mhevery merged commit 752e919 into QwikDev:main Mar 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants