Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the event listener on the window to use the capture option #6087

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Apr 3, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Apr 3, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5aaa5b6

@mhevery mhevery merged commit c7792f1 into QwikDev:main Apr 3, 2024
25 checks passed
@wmertens
Copy link
Member

wmertens commented Apr 4, 2024

Does this also solve #6084 @ITakayuki?

@ITakayuki
Copy link

@wmertens
No, it doesn't seem to have been resolved yet.
The problem with #6084 is that the contents of processReadyStateChange are not executed unless hasInitialized is set back to 0, so I think that needs to be fixed as well.

@Varixo Varixo deleted the fix-register-win-events branch April 27, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants