Add OverallDoorToWallRatio to Building #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macintoshpie
added
Schema: General
2020-09-25 Deliverable
automation
moved this from Review in progress
to Reviewer approved
Sep 23, 2020
markborkum
approved these changes
Sep 23, 2020
corymosiman12
approved these changes
Sep 24, 2020
macintoshpie
force-pushed
the
feat/overall-door-wall-ratio
branch
from
104cb51
to
5a65340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
STD 211 6.2.1.2.b requires "Total area of the fenestration". BuildingSync already has OverallWindowToWallRatio, but not OverallDoorToWallRatio.