Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AverageAnnualOperatingHours #311

Merged
merged 3 commits into from Mar 31, 2021

Conversation

JieXiong9119
Copy link
Contributor

See proposal
Implementation in schema added

Copy link
Contributor

@macintoshpie macintoshpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any great feedback but it feels a bit weird to only include this for OnsiteStorageTransmissionGenerationSystemType. Also feels a bit weird to include this type of info in this section. Feels more like something of an auc:ScheduleType or something?

You all would know better than I would what makes the most sense though

Copy link
Contributor

@corymosiman12 corymosiman12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@corymosiman12
Copy link
Contributor

@macintoshpie tracking your thoughts here: #312

@nllong
Copy link
Member

nllong commented Mar 23, 2021

I agree with @macintoshpie that this seems like a schedule thing; however, having average annual values in a time series schedule seems a bit strange. Unless in our ScheduleType world we have statistics about underlying schedules... somethign like (pseudocode below--any relationship to bsync is coincidental)

<schedule>
  <average_daily>27</average_daily>
  <average_monthly_during_occupied_hours>20</>
  <schedule_values_by_hour>
     <hour_1>10</>
     <hour_2>12</>
     ...
  </schedule_vlaues_by_hour>
</schedule>

All of this said, I think that we should go forth with the PR as is.

@nllong nllong merged commit cfd605d into develop Mar 31, 2021
@nllong nllong deleted the proposals/average-annual-operating-hours branch March 31, 2021 16:42
@JieXiong9119 JieXiong9119 changed the title Proposals/average annual operating hours Add AverageAnnualOperatingHours Sep 27, 2021
@JieXiong9119 JieXiong9119 added the Schema: Systems Update to systems label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality to BuildingSync Non-breaking Change Schema: Systems Update to systems UDFs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants