Remove redundant items #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
requested changes
Apr 19, 2021
There was a problem hiding this comment.
This is great, thanks Jie! A couple things:
- we need to base the PR against a new
develop-v3branch which I will create today. - Can you add a proposal into the proposal folder so that we know what this change is?
- After 2, can we also include Jan and Michael Braunch from CTS on these updates?
Will do! |
This was
linked to
issues
Apr 20, 2021
Hey Nick, please check the added proposals for the changes. |
|
Great, thanks! I added Yan as a reviewer. Can you send link to CTS? I'll slack you the email. |
yan130
approved these changes
Apr 21, 2021
nllong
approved these changes
Apr 27, 2021
JieXiong9119
commented
May 3, 2021
|
|
||
| ## Justification | ||
|
|
||
| `Install or upgrade master venting` measure repeats in `ChilledWaterHotWaterAndSteamDistributionSystems` and `OtherHVAC`, and we should keep only one of them. This proposal suggests that we remove it under `ChilledWaterHotWaterAndSteamDistributionSystems` and keep it under `OtherHVAC`, as master venting approach could be implemented not only in chilled or hot water system. |
There was a problem hiding this comment.
@nllong could we justify whether we should keep it under ChilledWaterHotWaterAndSteamDistributionSystems or OtherHVAC? Any reference to look up?
There was a problem hiding this comment.
I would check ASHRAE Standard 100.
This was
linked to
issues
May 4, 2021
Ryoken
approved these changes
May 4, 2021
nllong
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issues #271, #272, #275