Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate eGRIDRegionCode #394

Merged
merged 5 commits into from Sep 29, 2021
Merged

Deprecate eGRIDRegionCode #394

merged 5 commits into from Sep 29, 2021

Conversation

JieXiong9119
Copy link
Contributor

Follow-up updates on #358

@JieXiong9119 JieXiong9119 added Schema: General General update to BuildingSync Breaking Change labels Sep 28, 2021
@JieXiong9119 JieXiong9119 self-assigned this Sep 28, 2021
@JieXiong9119 JieXiong9119 linked an issue Sep 28, 2021 that may be closed by this pull request
Primary, Secondary and Tertiary eGRID Subregion Codes #358
Closed
@JieXiong9119
Copy link
Contributor Author

Need to update v2-to-v3 translator to include this change

macintoshpie
macintoshpie reviewed Sep 28, 2021
View reviewed changes
Copy link
Contributor

@macintoshpie macintoshpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema changes looks perf, let me know if you want a second pair of eyes on the translator stuff

@JieXiong9119
Copy link
Contributor Author

Schema changes looks perf, let me know if you want a second pair of eyes on the translator stuff

Should be good for final review now.

nllong
nllong approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

macintoshpie
macintoshpie reviewed Sep 29, 2021
View reviewed changes
Copy link
Contributor

@macintoshpie macintoshpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we just need to update a comment in the translator

translation/v2_to_v3.xsl Outdated Show resolved Hide resolved
@JieXiong9119 JieXiong9119 merged commit 3f207c4 into develop-v3 Sep 29, 2021
@JieXiong9119 JieXiong9119 deleted the deprecate/egridregioncode branch September 29, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macintoshpie macintoshpie macintoshpie left review comments

@nllong nllong nllong approved these changes

Assignees

@JieXiong9119 JieXiong9119

Labels
Breaking Change enhancement Schema: General General update to BuildingSync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Primary, Secondary and Tertiary eGRID Subregion Codes
3 participants
@JieXiong9119 @nllong @macintoshpie