#756 autocomplete suggestions v2 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,4 +29,24 @@ export class DeviceDataSource extends GraphQLDataSource { | |||
| async getPoints(deviceId: string): Promise<Point[]> { | |||
| return this.deviceDAO.getPoints(deviceId); | |||
| } | |||
|
|
|||
| async getDeviceNames(term?: string, limit?: number): Promise<String[]> { | |||
There was a problem hiding this comment.
lets call this something like 'search' or 'filter' isntead of term
| return searchOptions.sortOptions ? getSort(searchOptions.sortOptions) : { _id: 1 }; | ||
| } | ||
|
|
||
| private async getDistinct(field: string, term?: string, limit?: number): Promise<string[]> { |
There was a problem hiding this comment.
limit needs to be validated/defaulted
slevertbiot
approved these changes
May 12, 2022
added 8 commits
May 16, 2022 15:06
…enerate proper suggestions
mspratt-biot
force-pushed
the
#756-AutocompleteSuggestionsV2
branch
from
eb0f031
to
5d734aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.