#1341 setup sites screen #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevertbiot
reviewed
Aug 18, 2022
| }); | ||
| } | ||
|
|
||
| ngOnDestroy() { |
slevertbiot
reviewed
Aug 18, 2022
| } | ||
|
|
||
| filterData = (filters: SearchFilterItem[]): void => { | ||
| // arrow to hold onto this |
There was a problem hiding this comment.
filterData will be used in the html template and passed in as a callback to another component down the line. so this will reference the callbacks component instead of this one. Arrow functions hold onto this.
|
I approve of this MR. 😄 |
slevertbiot
approved these changes
Aug 19, 2022
slevertbiot
approved these changes
Aug 23, 2022
mspratt-biot
force-pushed
the
#1341-SetupSitesScreen
branch
from
eb5c48e
to
7363ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.