#1367 add columns to sites list view #223
Conversation
udmif/api/src/server/datasources.ts
Outdated
| @@ -5,7 +5,16 @@ import { Site } from '../site/model'; | |||
| import { DeviceDataSource } from '../device/DeviceDataSource'; | |||
| import { SiteDataSource } from '../site/SiteDataSource'; | |||
|
|
|||
| export default function dataSources(deviceDAO: DAO<Device>, siteDAO: DAO<Site>): () => DataSources<object> { | |||
| interface DS { | |||
There was a problem hiding this comment.
I'd prefer DataSources as an interface name. Although that will conflict with DataSources. :)
| export interface SitesArgs { | ||
| searchOptions: SearchOptions; | ||
| } | ||
|
|
||
| export interface SiteArgs { | ||
| id: string; | ||
| } |
There was a problem hiding this comment.
We may want to add docs to highlight the differences between Site and Sites
There was a problem hiding this comment.
Why is a singular site only accepting an id while the plural site interface accepting an object with more args?
There was a problem hiding this comment.
I thought is what typescript is for, just go see where this interface is used. if we do this, then we should comment all the interfaces everywhere. also, take a look at the device resolver, no types were ever provided into these functions params
There was a problem hiding this comment.
should i just remove the types from the site resolver?
udmif/api/src/site/resolvers.ts
Outdated
| site.validation?.summary.correct_devices.length, | ||
| site.validation?.summary.missing_devices.length, | ||
| site.validation?.summary.error_devices.length, | ||
| site.validation?.summary.extra_devices.length, |
There was a problem hiding this comment.
site.validation?.summary can be extracted to a local var and reused.
| "resolveJsonModule": true, | ||
| "esModuleInterop": true, |
There was a problem hiding this comment.
They allow json to be imported as an es module like all the ways we import instead of requiring.
No description provided.