Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom filter classes and fix multiple filter annotations #1

Merged
merged 3 commits into from Apr 8, 2016
Merged

Conversation

onlime
Copy link
Contributor

@onlime onlime commented Apr 7, 2016

Previously, only a single @Filter annotation was possible. If you added multiple @Filter annotations to the same entity property, only the first one was honored, the others got ignored. You might also add a test for this.
Next to the default Zend\Filter classes, we should also allow our own custom app/bundle specific filter classes that extend Zend\Filter\AbstractFilter.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #1 into master will not affect coverage as of c658ad4

@@            master      #1   diff @@
======================================
  Files            7       7       
  Stmts           91      91       
  Branches         0       0       
  Methods         21      21       
======================================
  Hit             91      91       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of c658ad4

Powered by Codecov. Updated on successful CI builds.

@Bukashk0zzz
Copy link
Owner

I will merge this and than add tests. Also I remove changes from .gitignore because some of folders must be ignored in your local global gitignore (https://insight.sensiolabs.com/what-we-analyse/git.user_specific_ignored_file)

@Bukashk0zzz Bukashk0zzz merged commit 30bfa22 into Bukashk0zzz:master Apr 8, 2016
@onlime
Copy link
Contributor Author

onlime commented Apr 9, 2016

Thanks a lot for the merge and the great test coverage in 1.0.1. Sorry about the changes in .gitignore - you're absolutely right. Nice you have pointed me to the global gitignore which I was actually using but completely forgot about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants