Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to specify delivery-options for the offer #28

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

veezex
Copy link
Contributor

@veezex veezex commented Sep 20, 2019

Hi, I added the ability to specify a delivery options for all types of offers.
Also added a new test and DTD for it

@Bukashk0zzz
Copy link
Owner

Hi,
Thanks for request. If it pass tests I will merge it.

@veezex veezex force-pushed the master branch 3 times, most recently from ead6b57 to ed1f172 Compare September 20, 2019 09:52
@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #28 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #28      +/-   ##
===========================================
+ Coverage     99.59%   99.6%   +<.01%     
- Complexity      267     271       +4     
===========================================
  Files            19      19              
  Lines           741     751      +10     
===========================================
+ Hits            738     748      +10     
  Misses            3       3
Impacted Files Coverage Δ Complexity Δ
src/Generator.php 100% <100%> (ø) 51 <2> (+2) ⬆️
src/Model/Offer/AbstractOffer.php 98.37% <100%> (+0.04%) 67 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb6bd1...5815732. Read the comment docs.

@veezex
Copy link
Contributor Author

veezex commented Sep 20, 2019

Finally, corrected it

@Bukashk0zzz Bukashk0zzz merged commit 6375fbf into Bukashk0zzz:master Sep 20, 2019
@Bukashk0zzz
Copy link
Owner

Added new tag https://github.com/Bukashk0zzz/YmlGenerator/releases/tag/v1.10.0

In few minutes it will come to composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants