Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Added list sorting to features page #23

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Added list sorting to features page #23

merged 2 commits into from
Jun 9, 2020

Conversation

yiftahb
Copy link

@yiftahb yiftahb commented Jun 3, 2020

Added the ability to sort a list in the PanelSearch component

kyle-ssg
kyle-ssg reviewed Jun 3, 2020
View reviewed changes
Copy link
Member

@kyle-ssg kyle-ssg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Thanks for this, I'll be reviewing it later today / running it through our E2E tests.

@kyle-ssg kyle-ssg changed the base branch from master to sorting-features June 9, 2020 16:58
kyle-ssg
kyle-ssg approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@kyle-ssg kyle-ssg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with manual testing, I'll have to adjust end-to-end tests to compensate for default sort. I'll let you know when this is live.

@kyle-ssg kyle-ssg merged commit 0164f76 into Flagsmith:sorting-features Jun 9, 2020
@kyle-ssg kyle-ssg mentioned this pull request Jun 9, 2020
Merged
@dabeeeenster
Copy link
Contributor

👍

@kyle-ssg
Copy link
Member

kyle-ssg commented Jun 9, 2020

@yiftahb just to let you know this is now live. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yiftahb @dabeeeenster @kyle-ssg