This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Allow the bullet train js client to respect api variable #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-ssg
suggested changes
Jun 18, 2020
There was a problem hiding this comment.
This is really useful and on my todo! However the implementation can't work like this for us, we'd need to configure Project.api and this separately.
In our dev builds of Bullet Train we still want to point to the production api for bulletTrain.init but our actual API calls in the admin interface to point to the develop API.
If you're doing this can we make it Project.bulletTrainClientAPI or something similar?
|
Sounds good, i will implement it as Project.bulletTrainClientAPI and make the updates across the files that will need a reference to it. |
|
Awesome cheers for helping out on this! |
…also allow for env variable override.
kyle-ssg
approved these changes
Jul 6, 2020
|
Awesome, thanks @amammay! |
|
Just to let you know this is now also in our production code, thanks again @amammay 🚀 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something small i found when i was setting up the full stack for bullet train on our own custom domains.