Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Commit

Permalink
Changed '.' with 'source' for readability
Browse files Browse the repository at this point in the history
  • Loading branch information
@Samsagax
Samsagax committed Aug 18, 2011
1 parent b096b5e commit 222cf3b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion install
View file
Expand Up @@ -41,7 +41,7 @@ install_step detectoldversion
# definition of tools (like $LSPCI) as well as command options parsing and
# options like installation path. It's a special case as it needs to be able to
# access the commandline options, therefore do not use install_step
. stages/setvars
source stages/setvars

This comment has been minimized.

Sign in to view

Copy link
@paulvriens

paulvriens Aug 20, 2011

Contributor

I've seen several issues on the old bumblee with using 'source' instead of '.'. Mainly because people couldn't read and did a 'sh install.sh' instead of either using bash or relying on the Sha-Bang.

This comment has been minimized.

Sign in to view

Copy link
@Lekensteyn

Lekensteyn Aug 20, 2011

Member

What does sh vs bash have to do with this change? Because of the sh install.sh confusion, we've decided to drop the .sh extension already.

This comment has been minimized.

Sign in to view

Copy link
@Samsagax

Samsagax Aug 20, 2011

Author Member

This will depend on system configuration, when 'sh' points to '/bin/dash' that would fail, same as a lot of our code. When bash is used there is no problem. We just have to make sure that no one uses 'sh' before any of our executable files.

This comment has been minimized.

Sign in to view

Copy link
@Lekensteyn

Lekensteyn Aug 20, 2011

Member

Fixed bash issue in cdd23d2
install_step checkprivileges

Expand Down

0 comments on commit 222cf3b

Please sign in to comment.