Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for proper unloading modules (#699) #717

Closed
wants to merge 1 commit into from
Closed

Possible fix for proper unloading modules (#699) #717

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2015

Original rmmod doesn't resolve module dependencies. That's why we can't unload nvidia module, because of nvidia_modeset or nvidia_uvm. I think, that modprobe -r will resolve that problem, because it tries to unload all unnecesary, dependent modules.

@ghost ghost mentioned this pull request Dec 27, 2015
@arafey
Copy link

arafey commented Dec 27, 2015

Unfortunately, in my case this was insufficient because driver nvidia was in use by nvidia_modeset and not the other way around. So modprobe -r nvidia would fail but modprobe -r nvidia_modeset would unload both modules successfully. I don't know why there is an inconsistency here, I'm probably missing something.

Assuming that the inconsistency is unavoidable, then this function should "hunt" for the correct module to unload by trying modprobe -r nvidia, checking the result, trying modprobe -r nvidia_modeset, checking the result, and so on.

EDIT: Just saw your newer code in #709. You should probably update the PR since that code is superior.

@ArchangeGabriel
Copy link
Member

This is already the case in the develop branch (against which one you should work and push): 1ada79f, but it has huge issues in Ubuntu at least. I’m working on it. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants