Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a public Xur API #502

Closed
vthornheart-bng opened this issue May 24, 2018 · 38 comments
Closed

Provide a public Xur API #502

vthornheart-bng opened this issue May 24, 2018 · 38 comments
Labels
bug filed A bug has been filed in BNet's internal bug tracking system for this request/report. enhancement ready for release

Comments

@vthornheart-bng
Copy link
Contributor

It has been requested that we revive the old public Xur API! I think that's a good idea, let's do that when we get the time.

@joshhunt
Copy link

This would be very helpful!

To display Xur listings on destinysets.com to unauthenticated users, I have to run my own Xur API, which a couple of other people use as well. Problem is maintenance and uptime isn't my strong suit, so it would be great if I didn't have to worry about this any more.

@janweinen
Copy link

yes please!

@danilkhromov
Copy link

So there is no way i can get xur inventory without asking users to authenticate?

@mattbaker
Copy link

This would be really nice for bots and the like (really, accessing any vendor), especially given how cumbersome the oauth flow is

@vthornheart-bng
Copy link
Contributor Author

Yes, I agree! With Triumphs and Forsaken work, this has had to take a back seat for the time being: but it is on our backlog!

@mattbaker
Copy link

Awesome!! Our future Xur bots thank you :)

@lowlines
Copy link

This should probably include all vendors, not just Xur. It'd be good if you could specify which vendors you want to return depending on your needs.

@nine13tech
Copy link

Because of his not specific to a charter nature and the event like status he held, could this not be part of a public vendors endpoint?
Are their plans for a public vendors endpoint that only shows the static or rotating vendor items that are always for sale or is that a authed endpoint only?

@ckhicks
Copy link

ckhicks commented Aug 24, 2018

Does the latest TWAB nullify any of these plans?

Xûr
  His will is not his own
    Will no longer display a vendor icon on destination maps

@vthornheart-bng
Copy link
Contributor Author

Still to be determined on the endpoint overall - but one way or another, I won't be allowed to return destination information for him.

@michabbb
Copy link

so in other words, there will be no chance to get his position by API ? we have to wait till some youtuber finished his search for him ? 🤔 😖

@vthornheart-bng
Copy link
Contributor Author

Sorry guys - design decisions overrule my preference for more data.

@justrealmilk
Copy link

justrealmilk commented Aug 24, 2018 via email

@vthornheart-bng
Copy link
Contributor Author

Yeah, all of that will still be there in the existing Vendors endpoint. Still TBD on the idea of having a public Xur endpoint though.

@ckhicks
Copy link

ckhicks commented Aug 24, 2018

All good, thanks for keeping us updated. 👍

@lowlines
Copy link

lowlines commented Aug 24, 2018

A couple of us in the community were talking about setting up an endpoint for returning his current location based on a manual dataset I will probably set up and maintain as part of my maps project. Assuming there are a finite number of locations for him to be in, eventually we will have a complete dataset and just need to specify which id is active. I'll probably make a direct link for the maps along the lines of
https://lowlidev.com.au/destiny/maps/xur

The one hiccup is that reset now happens at 3.30am for me, so I won't be able to update the current location in a timely manner.

@michabbb
Copy link

maybe the rss feed of findxur.com is a reasonably good solution, until someone provides a real api 🤔

@michabbb
Copy link

michabbb commented Nov 5, 2018

hi all, since finxur.com seems to be down or broken, i am really searching for a reliable source to get this info. is anybody planing something here ? maybe we can create a community build API for this, where the users can report xur´s location with one single click. based on the number of clicks by location, we could take this info as (most) correct info. on the other hand, we could select some public websites and grep the info from there, as soon as it´s available.
is somebody interested in a project like this ? or is there a better idea ?

@mattybeard
Copy link

hi all, since finxur.com seems to be down or broken, i am really searching for a reliable source to get this info. is anybody planing something here ? maybe we can create a community build API for this, where the users can report xur´s location with one single click. based on the number of clicks by location, we could take this info as (most) correct info. on the other hand, we could select some public websites and grep the info from there, as soon as it´s available.
is somebody interested in a project like this ? or is there a better idea ?

https://braytech.org/creators/ and our friend @justrealmilk

@michabbb
Copy link

michabbb commented Nov 9, 2018

@mattybeard nope... braytach changed, the xur api no longer is working, oh boy, this is so stupid of bungie that people have to search for xur´s location every f... week 😠 every stupid friday i need to search google to find his location instead of using the bungie api 😕

@ArkahnX
Copy link

ArkahnX commented Nov 9, 2018

Lets keep our comments polite and friendly here, Bungie is providing us with a huge service by allowing us to use their APIs, and even so much as officially supporting them this time around, so lets keep things friendly!

@justrealmilk
Copy link

justrealmilk commented Nov 11, 2018

@mattybeard friend!
@michabbb noticed your issue on my repo and discovered github notifications.
if it really is so desired, I guess I could apply some priority time to xur and api.braytech.org stuff
I didn't bother re-making the page these past weeks during my transition to react because xur's inventory is all old boring stuff. I still keep his sales data updated but to save me from manually adjusting his location data after the fact, I've been up at 3am (reset time for Brisbane, Australia) waiting for reddit to find him before changing a PHP variable and running the script that adds the week to my database.

@michabbb
Copy link

@justrealmilk i guess you don´t have to be awake for that ;) i have a cronjob myself that starts severel times after xurs location should be visible. i searched a few blogs that could be parsed easily (the html dom) - now i have found another one that works, as long they use the same layout. the point is: yes, nobody cares about xurs and his boring old stuff. for me it´s only a part that belongs to the weekly stuff where i notify my community about changes. most don´t care about xur, but some do. it´s annyoing that some things never found their way to the api, like the calus raid counter order, which weapons you can get on the EP this week. the community always has to find workarounds for this stupid things, that are important to many players.

that´s why i asked here: maybe it´s an idea to create a public api for everybody with infos, bungie is unable to provide, accessable for every developer, managed by the community.

it´s just an idea.....

@floatingatoll
Copy link

floatingatoll commented Nov 11, 2018 via email

@justrealmilk
Copy link

@michabbb, @floatingatoll I don't think he's calling Bungie's decision stupid, but rather, the circumstance we find ourselves in. This is less about Xur, and more about the vendor endpoint requiring auth in general. My understanding, from what I've gleaned from @vthornheart-bng, is that the endpoint is super intertwined with our systems, and while there are some should we at all and how should we decisions, the technical complexities that rise from separating the endpoints from its complicated internal web versus priority of requests is what really keeps use from getting a public endpoint for xur.

People like me exist though.

https://api.braytech.org/?request=xur&get=history
https://api.braytech.org/?request=vendor&hash=672118013

@floatingatoll
Copy link

floatingatoll commented Nov 11, 2018

@vthornheart-bng‘s reply above explicitly says that the game designers have prohibited the official API from publishing Xûr’s location:

#502 (comment)

@justrealmilk
Copy link

I said nothing of his location 🙈

@floatingatoll
Copy link

In two previous replies in this thread you specifically talked about location and being disappointed in Bungie for withholding it. I apologize for confusing your prior comments on this specific issue with your most recent comments on this specific issue, and will mute and exit this thread immediately.

@vthornheart-bng
Copy link
Contributor Author

vthornheart-bng commented Nov 11, 2018

Ah, you're talking about the fact that we don't have a public Xur endpoint rather than the location info? In that situation, it's a matter of the time that we have vs. the higher priority work that we have to get to. In the end, you're talking right now to the only person actively working on the Destiny API. Whatever I have the ability to do in my workday is what gets done in the API: that's balanced between

  • Other external API asks and bugs
  • Non-Destiny-related Bungie.net work
  • Work that has to be done to maintain the API when new game releases break us or change systems in a way that we have to handle
  • Internal work (tools, import, our content management system, etc...)

The public Xur endpoint is something I want to provide! I haven't had time to work on it yet, but it is something I would personally put high on the winter wishlist - so hopefully we can make it happen during the upcoming holiday season!

(But just to note, it won't have location no matter what: indeed I have been asked not to return that information)

@michabbb
Copy link

oh boy, I thought it would be allowed to say what you think, but it seems that you are complaining about the choice of words rather than constructive suggestions. i´m out. thanks.

@vthornheart-bng
Copy link
Contributor Author

Hey y'all, let's all be little Fonzies here. No need to fight - it's easy to misinterpret what people say/people's intent on the internet, and for that to snowball.

@VeraxonHD
Copy link

VeraxonHD commented Dec 16, 2018

(But just to note, it won't have location no matter what: indeed I have been asked not to return that information)

Confused about this. Surely determining the location of Xur is, like, really easy? As in, just look at where the flashpoint is and go to the same position as he always is on that planet? Why not include that information?

Also any update to this? I don't think @justrealmilk 's braytech.org api has been updated in a while so this would be real useful about now.

@justrealmilk
Copy link

@VeraxonHD Xur isn’t tied to flashpoint any longer.

As for my private endpoint, I don’t personally use it at this point and as I have no insights as to its use by others, I find it really difficult to feel invested in maintaining it.

@VeraxonHD
Copy link

VeraxonHD commented Dec 16, 2018

@VeraxonHD Xur isn’t tied to flashpoint any longer.

Ah, right, of course.

As for my private endpoint, I don’t personally use it at this point and as I have no insights as to its use by others, I find it really difficult to feel invested in maintaining it.

I used it, for lack of any other alternative, and it was really helpful considering I haven't the time to boot up the game and enter it manually. But that's understantable.

@vthornheart-bng
Copy link
Contributor Author

Aye, I was specifically asked not to return location information in the endpoint unfortunately. I know that's a bummer for those who use it - sorry that I can't provide it!

Now that it's the week between Christmas and New Year's, I finally have some time to carve out for winter wishlist work. This one's the next one down in my hit list! I'll let you know when I've got something ready, and the details of what it is.

@vthornheart-bng
Copy link
Contributor Author

vthornheart-bng commented Dec 26, 2018

TFS 330631, filed ages ago and long left in the dark corner of our backlog

@vthornheart-bng vthornheart-bng added the bug filed A bug has been filed in BNet's internal bug tracking system for this request/report. label Dec 26, 2018
@vthornheart-bng
Copy link
Contributor Author

Okay, so after a bit of hassle trying to find a more generic way to potentially return more information than just Xur, I found that character-agnostic Vendor information is even hairier now than I realized. I'm going to return just Xur from this endpoint, who is currently the only vendor that I'm certain doesn't have meaningful character-specific sale items. Someday I'd like to talk more on the subject, but I fear if I did that I'd go too deep into the secret sauce. I'd likely be summarily executed.

Anyways, this is ready for the January deployment - but for the forseeable future it will only have Xur in it. Which I guess is all anyone wanted, but I was personally hoping for more. Oh well.

@vthornheart-bng
Copy link
Contributor Author

This should be fixed as of today's deployment (1/29)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug filed A bug has been filed in BNet's internal bug tracking system for this request/report. enhancement ready for release
Projects
None yet
Development

No branches or pull requests