Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~12/11 - The manifest will start including JSON-formatted Destiny definitions #785

Closed
hellocontrol-bng opened this issue Nov 22, 2018 · 5 comments

Comments

@hellocontrol-bng
Copy link

Heads up!

In our first major December deployment, we will start including JSON-formatted Destiny definitions, in addition to the existing SQLite database that is already included. The SQLite database will continue to exist alongside the JSON definitions.

The JSON definitions will come as one single file, formatted as a large object following this schema:

{
   "DestinyInventoryItemDefinition": 
   {
       "362514080": 
       {
           "displayProperties": 
           {
               "description": "",
               "name": "Common Gear",
               "icon": "/common/destiny2_content/icons/399ff8844f8a4ec8301143efb680aa35.jpg",
               "hasIcon": true
           }
           // etc
       }
   }
}

You will start seeing a new property in the manifest result entitled jsonWorldContentPaths, which will be similar to the SQLite property that is already there.

Speak up if you have questions or comments!

@lowlines
Copy link

lowlines commented Nov 22, 2018

That's one json file for each definition table correct? The InventoryItem table must be huge!

@hellocontrol-bng
Copy link
Author

@lowlines As it is, it's one JSON file that includes all definitions. After compression, it currently clocks in around 5.2mb.

@joshhunt
Copy link

joshhunt commented Dec 2, 2018

What do you think the chances are of having per-table JSON files? If there was a chance to not download all the tables, I think that would be a win (especially if you're not interested in InventoryItems!

@cowgod
Copy link

cowgod commented Dec 3, 2018

That was my thought as well. I seldom need every single table — most of my projects only involve 3-4 at the most. One JSON file per table seems like a more logical arrangement to me, but I assume you guys had some rationale for combining them all into one.

FWIW, while at first I was excited about the prospect of being able to strip out the messy sqlite manifest processing portion of my projects’ code, I don’t think I’ll end up migrating them to use the new file, as I worry that parsing a huge 5mb JSON would put more memory load etc on my system than the current implementation involving SQLite.

@vthornheart-bng
Copy link
Contributor

Fixed as of v2.3.3 deployment (12/11)!

alexanderwe added a commit to alexanderwe/the-traveler that referenced this issue Dec 23, 2018
Bungie-net/api#785 added URL to json definition files in the manifest information. To download those, this method is addded:

Fixes: #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants