Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: show html tags in description #84

Closed
pippinmole opened this issue Jan 21, 2024 · 8 comments · Fixed by #85 or #106
Closed

enh: show html tags in description #84

pippinmole opened this issue Jan 21, 2024 · 8 comments · Fixed by #85 or #106

Comments

@pippinmole
Copy link

This bit of code:

jobs = scrape_jobs(
    site_name=["linkedin"],
    search_term="software engineer",
    location="Texas, US",
    results_wanted=15,
    country_indeed='US'  # only needed for indeed / glassdoor
)

returns a description, but does not contain any \n characters. This means when rendering the text it comes out as one big block of text:

image

@cullenwatson
Copy link
Member

linkedin currently does not fetch the description. did you mean another site?

@pippinmole
Copy link
Author

Hi, yes I did. My apologies, I meant Indeed.

@cullenwatson
Copy link
Member

Should readd html, better integrations for users

@pippinmole
Copy link
Author

What do you mean by 'readd html'?

@cullenwatson
Copy link
Member

cullenwatson commented Feb 9, 2024

I mean show the html tags so people can embed the jobs within their own sites with the same structure. Right now the code strips the tags so need to readd it

@cullenwatson cullenwatson changed the title bug: Description doesn't capture new line character enh: show html tags in description Feb 9, 2024
@cullenwatson cullenwatson mentioned this issue Feb 12, 2024
@pippinmole
Copy link
Author

Hi,

I'd just like to point out that while the html structure is brilliant, and renders perfectly, it isn't the greatest idea to be using HTML if users of this tool expect to merge the scraped data with other job post sources.

Currently, I throw all job posts in a database, with the description column containing the HTML which has been scraped. I'd also like to allow for companies to submit their own job applications via a web form on my site. Unfortunately, the way it is currently means they have to know html (because the scraped jobs are html). I'd like them to be able to use a markdown editor which is much easier for non-tech individuals to understand.

Is there a possibility to allow an output of markdown?

@ZacharyHampton
Copy link
Member

I think having us do the HTML to markdown is quite out of scope.

@cullenwatson
Copy link
Member

Yea probably should've just left it as markdown by default. But since I added the HTML, already had the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants