-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce baseline and TLS configs to lifecycle #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️ Nice improvement! Just had a few non-blocking comments.
lifecycle/README.md
Outdated
``` | ||
|
||
Scale 5 lifecycle namespaces to 3 replicas of `bb-broadcast`, `bb-p2p`, and | ||
Scale 5 lifecycle environments to 3 replicas of `bb-broadcast`, `bb-p2p`, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
Scale 3 lifecycle environments to 3...
lifecycle/bin/scale
Outdated
kubectl -n $NS_TLS scale --replicas=$REPLICAS deploy/bb-broadcast deploy/bb-p2p deploy/bb-terminus | ||
|
||
echo "\nScaling $NS_BASELINE to $REPLICAS replicas..." | ||
kubectl -n $NS_BASELINE scale --replicas=$REPLICAS deploy/bb-broadcast deploy/bb-p2p deploy/bb-terminus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIOLI -- you could DRY this up a bit with a helper func.
function scale() {
kubectl -n $1 scale --replicas=$REPLICAS deploy/bb-broadcast deploy/bb-p2p deploy/bb-terminus
}
for i in `seq 1 $NAMESPACES`;
do
NS=lifecycle$i
scale "$NS"
scale "$NS-tls"
scale "$NS-baseline"
done
The existing lifecycle test environment runs a set of applications injected with Conduit. This change introduces a parallel set of applications that run without Conduit, to enable comparison, along with a TLS-enabled config. Part of #43. Signed-off-by: Andrew Seigner <siggy@buoyant.io>
b656dfb
to
9e982d1
Compare
The existing lifecycle test environment runs a set of applications
injected with Conduit.
This change introduces a parallel set of applications that run without
Conduit, to enable comparison.
Part of #43.
Depends on linkerd/linkerd2#1295.
Signed-off-by: Andrew Seigner siggy@buoyant.io