This repository has been archived by the owner on Jun 22, 2020. It is now read-only.
Issue #2915666: Integrate paragraphs split modul #428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbosen
suggested changes
Nov 6, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add integration tests for this module.
dbosen
reviewed
Nov 6, 2017
@@ -14,4 +14,5 @@ dependencies: | |||
- paragraphs:paragraphs | |||
- drupal:text | |||
- thunder:thunder_media | |||
- thunder_paragraphs:paragraph_split_text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency should be moved to the distribution
…rdaMagazinOrg/thunder-distribution into feature/2915666-paragraphs-text-split * 'feature/2915666-paragraphs-text-split' of github.com:BurdaMagazinOrg/thunder-distribution: Issue #2921294 by chr.fritsch: Decouple dependencies in Thunder Taxonomy Module
* develop: Issue #2921292 by chr.fritsch: Decouple dependencies in Thunder Media module and Issue #2921296 by chr.fritsch
dbosen
approved these changes
Nov 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before submitting your pull request - thank you!
If you are really awesome, then your feature is covered by additional tests. Well done!