Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

Issue #2915666: Integrate paragraphs split modul #428

Merged
merged 18 commits into from Nov 22, 2017

Conversation

chrfritsch
Copy link
Member

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add integration tests for this module.

@@ -14,4 +14,5 @@ dependencies:
- paragraphs:paragraphs
- drupal:text
- thunder:thunder_media
- thunder_paragraphs:paragraph_split_text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency should be moved to the distribution

@chrfritsch chrfritsch merged commit 6f4574c into develop Nov 22, 2017
@chrfritsch chrfritsch deleted the feature/2915666-paragraphs-text-split branch November 22, 2017 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants