Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

Issue #2924063: Add liveblog page is not aligned with article design #447

Merged
merged 9 commits into from Nov 17, 2017

Conversation

chrfritsch
Copy link
Member

@chrfritsch chrfritsch commented Nov 16, 2017

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

Copy link
Member

@ol0lll ol0lll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly looks better, anyhow I created a follow-up ticket in thunder_admin theme to address missing styles https://www.drupal.org/project/thunder_admin/issues/2924370
Also fixes https://www.drupal.org/project/liveblog/issues/2923389

@chrfritsch chrfritsch merged commit ce10b58 into develop Nov 17, 2017
@chrfritsch chrfritsch deleted the feature/2924063-liveblog-add-page branch November 17, 2017 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants