api: switch to extension traits #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit effectively rewrites the entire API of this crate to use extension traits on `[u8]` and `Vec<u8>`. While the `BStr` and `BString` types are still present, they are now just dumb wrappers that deref to `[u8]` and `Vec<u8>`, respectively. Their primary purpose is for convenient debug impls. The motivation for this design is laid out in #5. Closes #5
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit effectively rewrites the entire API of this crate to use
extension traits on
[u8]andVec<u8>. While theBStrandBStringtypes are still present, they are now just dumb wrappers that deref to
[u8]andVec<u8>, respectively. Their primary purpose is forconvenient debug impls.
The motivation for this design is laid out in #5.
Closes #5