Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Write for core #51

Closed
Ericson2314 opened this issue Jul 1, 2016 · 8 comments
Closed

Read Write for core #51

Ericson2314 opened this issue Jul 1, 2016 · 8 comments

Comments

@Ericson2314
Copy link

Ericson2314 commented Jul 1, 2016

@Tobba and I have worked on https://github.com/QuiltOS/core_io, a copy of Read and Write but with an associated error type to make it just need core. Perhaps it would be nice to (optionally) extend these traits for no_std users?

@BurntSushi
Copy link
Owner

@Ericson2314 I'd be willing to do so once coreio gains more traction.

@BurntSushi
Copy link
Owner

I'm going to close this but feel free to re-open if you think we should reconsider core-io!

@Ericson2314
Copy link
Author

Sure. Once I have a version on crates.io polished a bit I'll ping this.

@whitequark
Copy link

@BurntSushi Chiming in as I'm using core_io a bunch: I would very much like this to happen, but until jethrogb/rust-core_io#3 is resolved this would make the life of downstream crates harder.

@BurntSushi
Copy link
Owner

@whitequark That library is distinct from the one @Ericson2314 linked.

@whitequark
Copy link

@BurntSushi Oh. I'm much less happy with Ericson2314's library because it misses basic things (e.g. BufReader). I think the general direction of jethrogb's library (that is, mirroring std::io as closely as possible by being based on its codebase from the relevant libstd version directly) is correct, and from my audit I don't expect any other trouble after the two code-related issues I've opened are addressed.

@Ericson2314
Copy link
Author

FWIW the only reason there is no BufReader is because I haven't implemented it yet.

@whitequark
Copy link

Yes, that you are reimplementing parts that are already well-tested by virtue of shipping in std::io also bothers me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants