Simple fixes for #76 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @BurntSushi cc @dtolnay |
|
I forgot to update the docs in new.rs. Doing so now. |
|
Updated with error docs. |
|
cc #76 |
|
Awesome, thanks @brson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the html_root_url I used the exact docs.rs version and just put an obnoxious comment in the toml file to remind authors to update the two together. Other suggestions very welcome.
I did not specify either html_logo_url or html_favicon_url like many official Rust crates do since we didn't talk about it, but it seems like we need guidelines on those too.