Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fixes for #76 #78

Merged
merged 4 commits into from
Mar 28, 2017
Merged

Simple fixes for #76 #78

merged 4 commits into from
Mar 28, 2017

Conversation

brson
Copy link
Contributor

@brson brson commented Mar 4, 2017

For the html_root_url I used the exact docs.rs version and just put an obnoxious comment in the toml file to remind authors to update the two together. Other suggestions very welcome.

I did not specify either html_logo_url or html_favicon_url like many official Rust crates do since we didn't talk about it, but it seems like we need guidelines on those too.

@brson
Copy link
Contributor Author

brson commented Mar 4, 2017

r? @BurntSushi cc @dtolnay

@brson
Copy link
Contributor Author

brson commented Mar 4, 2017

I forgot to update the docs in new.rs. Doing so now.

@brson
Copy link
Contributor Author

brson commented Mar 4, 2017

Updated with error docs.

@brson
Copy link
Contributor Author

brson commented Mar 10, 2017

cc #76

@BurntSushi
Copy link
Owner

Awesome, thanks @brson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants