Go modules support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commt is the first step towards switching to Go modules, ref: BurntSushi#8
This commit adds Go modules support by switching to the new package that supports them in the golang tools repository. Closes BurntSushi#8
|
😄 now seeing #9 after opening this PR, closing this out in favor of that one. |
Closed
|
Awesome, thanks! It turns out that #9 isn't quite correct (see this comment), so I'm going to bring this one in instead! |
kujenga
added a commit
to kujenga/go-sumtype
that referenced
this pull request
Feb 27, 2019
This commit expands the capabilities of the tool so that it can check tests as well. This may or may not have been a regression introduced with: BurntSushi#10
BurntSushi
pushed a commit
that referenced
this pull request
Feb 27, 2019
This commit expands the capabilities of the tool so that it can check tests as well. This may or may not have been a regression introduced with: #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running this tool against Go modules.
With some of the new niceties in https://godoc.org/golang.org/x/tools/go/loader there may be some opportunities for further cleanup, but I've left that alone in this PR.
Testing on my machine, this looks to now be about twice as fast!
Closes #8