Adds a way to increase or decrease the gap between windows #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +78,18 @@ def clients(self): | |||
|
|
|||
| # End abstract methods; begin OrientLayout specific methods | |||
|
|
|||
| def expand_gap(self): | |||
| config.gap = config.gap + config.gap_change | |||
There was a problem hiding this comment.
This will cause pytyle3 to crash if you haven't updated your configuration. I'd like to avoid that.
Could you change references like config.gap_change to getattr(config, 'gap_change', 5)? Similarly in other places.
|
Looks good. If you fix up my concerns, I'll happily merge. :-) |
|
This should be good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I made a few changes to be able to increase/decrease the gaps between windows, a feature I liked in bspwm or dwm, can't remember which.
Although I am not sure that directly changing
config.gapis a good way of achieving this...It still needs to be tested on a multi monitor setup but this should work fine as far as I understand.
Here is a small demo :