Documentation added how to generate a struct #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbla
reviewed
Oct 3, 2019
Comment on lines
+386
to
+389
| Point { | ||
| x: g.gen(), | ||
| y: g.gen(), | ||
| } |
There was a problem hiding this comment.
This should be
Point {
x: i32::arbitrary(g),
y: i32::arbitrary(g),
}They way you did it depends on the rand api, which is prone to changing, see #241. Making my suggested change also obsoletes the accompanying notice (and the dependency hell that I think would come with it)
BurntSushi
pushed a commit
that referenced
this pull request
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR addressing the missing documentation how to generate a struct, aiming for improving the "first-time" user experience with the library.
For that simple use case I needed to dig into the code of QuickCheck to find out, how to generate a arbitrary struct. And I had troubles with the missing Rnd instance for the given type, so I've added a notice about this. Maybe it's worth to have own topic for this issue.
What do you think?