Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird non-matching error with ignore-case and certain strings containing non-ascii characters? #267

Closed
crumblingstatue opened this issue Dec 4, 2016 · 7 comments
Labels
duplicate An issue that is duplicative of another.

Comments

@crumblingstatue
Copy link

crumblingstatue commented Dec 4, 2016

I really don't know what to make of this.

I tried to search my project for "magnézium", ignoring case, but I didn't get any matches, even though I know the project has several instances of it.
So I did some test cases:

echo 'Néz' | rg -i néz
1:Néz

Good

echo 'Agnéz' | rg -i agnéz
1:Agnéz

Still good

echo 'Magnéz' | rg -i magnéz

What? This suddenly doesn't match, even though I only added a M letter?

echo 'Magnez' | rg -i magnez
1:Magnez

But wait... If I replace the non-ascii é with e, it matches again.

Using ripgrep 0.3.1. The non-matching case works correctly using grep or git grep.

@BurntSushi
Copy link
Owner

I suspect this is a dupe of #251, which is fixed on master. Namely, this works:

$ echo 'Magnéz' | rg -i magnéz
1:Magnéz

I meant to get a release out this weekend but got tied up with other things. I think CI is giving me trouble too. I'll try harder to get one out soon.

@BurntSushi BurntSushi added the duplicate An issue that is duplicative of another. label Dec 5, 2016
@ngirard
Copy link

ngirard commented Dec 7, 2016

I'm suspecting another dupe of #251 here. Tested under ripgrep 0.3.1:

echo "touré kunda" | rg 'touré.kunda'

returns nothing.
Note that ignore-case is not enabled in this case.

If it is already fixed in master, a new release would be highly appreciated.
Cheers, and many thanks for your great work!

@BurntSushi
Copy link
Owner

If it is already fixed in master, a new release would be highly appreciated.

I'm trying, but one of the tools I use to build releases is broken. People are working on fixing it. (I am specifically using the nightly version of said tool, so I get what I deserve, but nightlies are required to build executables with explicit support for SIMD.)

@ngirard
Copy link

ngirard commented Dec 7, 2016

Alright, then, I'll keep waiting :-)

@BurntSushi
Copy link
Owner

Awesome. Looks like whatever was broken has been fixed. A new release is popping out now! https://github.com/BurntSushi/ripgrep/releases --- Still waiting on Mac/Windows.

@ngirard
Copy link

ngirard commented Dec 7, 2016

Great !

@crumblingstatue
Copy link
Author

Alright, tested 0.3.2, and it indeed returns the same number of matches for "magnézium" as git-grep, so I'm going to trust this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate An issue that is duplicative of another.
Projects
None yet
Development

No branches or pull requests

3 participants