ignore: Simplify the work-stealing strategy #2624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavianator
force-pushed
the
simplify-work-stealing
branch
from
abc3e55
to
b18a8ec
Compare
|
Thanks! Out of curiosity, what prompted you to make this change? |
|
No particular reason, I happened to be looking at the code again and realized that stealing from your left neighbour or your right neighbour shouldn't make a difference (and indeed perf is the same in my benchmarks) |
BurntSushi
approved these changes
Oct 12, 2023
BurntSushi
added
the
rollup
BurntSushi
pushed a commit
that referenced
this pull request
Oct 12, 2023
There's no particular reason for this change. I happened to be looking at the code again and realized that stealing from your left neighbour or your right neighbour shouldn't make a difference (and indeed perf is the same in my benchmarks). Closes #2624
tavianator
added a commit
to tavianator/fd
that referenced
this pull request
Nov 1, 2023
sharkdp
pushed a commit
to sharkdp/fd
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.