Support ripgrep-bin installation with linuxbrew #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you tell me how to test this? I don't know what linuxbrew is. |
BurntSushi
reviewed
Oct 25, 2017
pkg/brew/ripgrep-bin.rb
Outdated
| sha256 "ac595c2239b9a30e0e0744578afa6b73e32cdd8ae61d4f1c0ee5d6b55adbadcf" | ||
| when /i686-linux/ | ||
| url "https://github.com/BurntSushi/ripgrep/releases/download/#{version}/ripgrep-#{version}-i686-unknown-linux-musl.tar.gz" | ||
| sha256 "6e64e7481fbe6019a873a078af13a4aa86ec57a6f94765fd8b57b40d8138560e" |
There was a problem hiding this comment.
Could you please remove the i686 option? I don't want to devote resources to something people probably won't use. I realize CI produces builds for it, but only because it doesn't cause any trouble. However, if I support this on linuxbrew and decide one day to remove support for it, people might get upset.
francoisferrand
force-pushed
the
ripgrep-bin-linuxbrew
branch
from
54aecfd
to
b6ac5da
Compare
|
Linuxbrew is a port of homebrew for Linux. Then install the |
BurntSushi
approved these changes
Oct 25, 2017
|
(I do incidentally test this tap on a Mac, but that's because my Mac is strictly for testing this sort of thing. I otherwise don't use it.) |
francoisferrand
force-pushed
the
ripgrep-bin-linuxbrew
branch
from
b6ac5da
to
eb5efb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.