Do not flush underlying writer when buffer becomes full #173
Comments
owst
added a commit
to owst/rust-csv
that referenced
this issue
Oct 6, 2019
BurntSushi
pushed a commit
that referenced
this issue
Jan 7, 2020
This fixes a bug where the CSV writer was erroneously flushing the underlying writer when its internal buffer was full. Instead, when the internal buffer is full, it should simply write the contents of the buffer to the underlying writer. There is no need to flush it. Indeed, this causes other problems such as those observed in BurntSushi/xsv#151. We are careful to ensure that calling `flush` explicitly still calls `flush` on the underlying writer. Fixes #173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of the
csvcrate are you using?master:
fcdbea357739348b9eed2a0239e180213be78af9Briefly describe the question, bug or feature request.
As mentioned in this issue of
xsv, it seems that rust-csv is flushing the underlying writer when its internal buffer becomes full. This causes issues forxsvas the underlying writer is aTabWriterand callingflushcauses side-effects other than writing out the buffer (specifically, it resets the internal state, "breaking" alignment of subsequently written data)Include a complete program demonstrating a problem.
The reproduction with
xsvis attached on the linked issue - using a smallrust-csvbuffer size leads to broken tabular layout.What is the expected or desired behavior of the code above?
When the internal buffer becomes full, its contents should be written to the underlying writer, but the underlying writer should not be
flushed. This seems to match with other buffering IO libraries, such asBufferedWriterin Java and rust's stdlibThe text was updated successfully, but these errors were encountered: